search

THUKEG / saedb

the SAE platform
http://thukeg.github.com/saedb/
11 stars 19 forks source link

Thread pool #61

Closed wweic closed 11 years ago

wweic commented 11 years ago

@thinxer , a cmake issue. I have added thread_pool as a lib in saedb/CMakeLists.txt, but when I build the project, still can't find thread_pool 's symbol? could you please help check the writing of CMakeLists.txt?

thinxer commented 11 years ago

It's not a CMake issue. You must put template implementations in the header file. In this case, ThreadPool::launch is a function template.

Also, I think passing a std::function<void()> parameter to launch should be enough. I don't get the idea to make it a function template.

On Mon, May 13, 2013 at 3:25 PM, Wei Chen notifications@github.com wrote:

@thinxer https://github.com/thinxer , a cmake issue. I have added thread_pool as a lib in saedb/CMakeLists.txt, but when I build the project, still can't find thread_pool 's symbol? could you

please help check the writing of CMakeLists.txt?

You can merge this Pull Request by running

git pull https://github.com/pondering/saedb thread-pool

Or view, comment on, or merge it at:

https://github.com/THUKEG/saedb/pull/61 Commit Summary

  • simple thread pool module
  • add size, join, test
  • add thread pool to syn engine, TODO: 1. fix cmake file 2. add lock to vertex program id

File Changes

  • M src/saedb/CMakeLists.txthttps://github.com/THUKEG/saedb/pull/61/files#diff-0(3)
  • M src/saedb/engine/synchronous_engine.hpphttps://github.com/THUKEG/saedb/pull/61/files#diff-1(14)
  • A src/saedb/util/CMakeLists.txthttps://github.com/THUKEG/saedb/pull/61/files#diff-2(13)
  • A src/saedb/util/thread_pool.cpphttps://github.com/THUKEG/saedb/pull/61/files#diff-3(86)
  • A src/saedb/util/thread_pool.hpphttps://github.com/THUKEG/saedb/pull/61/files#diff-4(62)
  • A src/saedb/util/threadpool_test.cpphttps://github.com/THUKEG/saedb/pull/61/files#diff-5(48)

Patch Links:

thinxer commented 11 years ago

This isn't really a pull request, or any problem relating to the functionality of the project. Closing.