Closed SASRec closed 1 year ago
Thanks for your contribution! I have tested and it seems to work well. Although the final results will be a little different from previous ones (cause the random process has been changed), the differences are generally negligible.
One question is whether it is fine to only add random permutation to the fit
function. It seems to be enough to prevent the model to remember the position.
Hi I guess adding random permutation to the fit
function should also be enough. Could you check the updated pull request? Thanks.
Creating this pull request for Issue #43 . I have added random permutation to the
fit
function andpredict
function so that the models cannot remember the first item being the target.I have created a new directory for this pull request because I have changed too many things in the original directory, and it might contain sensitive contents. However, I have tested the diff using the following two models and the results seem to be fine. In my original directory, the code works fine with KDA, SASRec, ComiRec and many other models. Please let me know if you observe otherwise.
I have added some comments to make the code easier to understand.