search

TIBCOSoftware / JS-FDSample

Sample web application demonstrating TIBCO Jaspersoft. Try it live at:
https://www.jaspersoft.com/fresh-delivery
GNU Affero General Public License v3.0
18 stars 33 forks source link

refactoring #1

Closed peter-mcrae closed 8 years ago

peter-mcrae commented 8 years ago

Hopefully I got this right....

sgwood63 commented 8 years ago

The README.md seems to have gone backward.

danielpetzold commented 8 years ago

Correct. I will save this file and simply upload after the merge. This is the only thing I have worked on since Peter's contributions.

Thanks for the heads up!

_Daniel Petzold_Product Manager

► _415.348.2368 <415.348.2343> / 615-507-0866 <415.734.1949> ►_dpetzold@tibco.com fdelle@tibco.com

On Wed, Jan 20, 2016 at 10:57 AM, Sherman Wood notifications@github.com wrote:

The README.md seems to have gone backward.

— Reply to this email directly or view it on GitHub https://github.com/TIBCOSoftware/JS-FDSample/pull/1#issuecomment-173324275 .

marianol commented 8 years ago

Looks like we lost the repo history. Why didn't we forked this form an existing repo or imported the whole repo no just a brand new commit?

danielpetzold commented 8 years ago

This repo should be originated (as all others) on the TIBCO GitHub repository. I've had this question come up many times and we discussed it in detail on our last call. No TIBCO GitHub repos should originate (fork) from repos outside of https://github.com/TIBCOSoftware. The entire point to the recent endeavor around GitHub (and permissions) was to ensure TIBCO ownership and origination of all samples, demos.

So the process is as follows. Origination of all repos on https://github.com/TIBCOSoftware, fork from this origination putting through PULL requests (employee only) to merge with the master branch. If there are any further questions around this matter feel free to reach out to me directly.

_Daniel Petzold_Product Manager

► _415.348.2368 <415.348.2343> / 615-507-0866 <415.734.1949> ►_dpetzold@tibco.com fdelle@tibco.com

On Fri, Jan 22, 2016 at 9:22 AM, Mariano Luna notifications@github.com wrote:

Looks like we lost the repo history. Why didn't we forked this form an existing repo or imported the whole repo no just a brand new commit?

— Reply to this email directly or view it on GitHub https://github.com/TIBCOSoftware/JS-FDSample/pull/1#issuecomment-173983828 .

marianol commented 8 years ago

I understand that (repos must be originated here and not forked) but losing the history has nothing to do with it, you can clone the repo locally and push it TIBCOSoftware without losing the repo history and without the need of forking, we do own all the code. This way you keep the history and originate the code from here. The current way looks like the repo is a COPY of other public repo(s).