TIBCOSoftware / mashling

Project Mashling
86 stars 15 forks source link

The mashling V2 binary created with mashling-cli.exe create command is generated outside the bin folder #172

Closed ykalidin closed 6 years ago

ykalidin commented 6 years ago

While creating app with mashling-cli.exe create command the binary is getting created in the mashling-custom folder outside the bin folder.

jeffreybozek commented 6 years ago

This was done by design so the executable would be at the top level of the folder and easy to find. After the binary is generated into the /release folder it is moved.

rameshpolishetti commented 6 years ago

On other note - should we delete src, pkg & bin folders so that user would have only useful mashling-gateway binary.

jeffreybozek commented 6 years ago

I guess it depends on if we think users will be inspecting generated code or re-compiling an already created gateway after further customizations. If yes, then keeping the src and intermediate artifacts could be useful. If not then we can probably delete all of those folders. Depending on how the customized mashling is created (native versus Docker) and what the user's environment looks like (dep or go-bindata existing or not), one can have entries in the /bin and /pkg folders.

rameshpolishetti commented 6 years ago

Placing the generated binary mashling-gateway.exe under bin folder is not necessary. Not treating this an issue.