TIBHannover / BacDiveR

Inofficial R client for the DSMZ's Bacterial Diversity Metadatabase (former contact: @katrinleinweber). https://api.bacdive.dsmz.de/client_examples seems to be the official alternatives.
https://TIBHannover.GitHub.io/BacDiveR/
MIT License
10 stars 12 forks source link

Open only 1 .Renviron editor window #68

Open katrinleinweber opened 6 years ago

katrinleinweber commented 6 years ago

A minor issue remains after #62: 2 editor windows are opened, upon devtools::install_github("tibhannover/BacDiveR") when no .Renviron file is present.

This is not very user-friendly. I already tried deleting:

https://github.com/TIBHannover/BacDiveR/blob/6e02a7bea888f71cde76581b4b5b82f20387abf9/R/prepare_Renviron.R#L46

and

https://github.com/TIBHannover/BacDiveR/blob/6e02a7bea888f71cde76581b4b5b82f20387abf9/R/utils.R#L14

but that either didn't change the behavior, or it stopped any editor window from opening. The latter seems less user-friendly, so I left #67 as it were.

Update

In a Debian installation, no editor window opened, and file.edit(file.path(Sys.getenv('HOME'), '.Renviron')) yielded a semi-error about the file being open already.