search

TIBHannover / BacDiveR

Inofficial R client for the DSMZ's Bacterial Diversity Metadatabase (former contact: @katrinleinweber). https://api.bacdive.dsmz.de/client_examples seems to be the official alternatives.
https://TIBHannover.GitHub.io/BacDiveR/
MIT License
10 stars 12 forks source link

Stop or warn if a dataset doesn't exist? #93

Closed katrinleinweber closed 5 years ago

katrinleinweber commented 5 years ago

Currently, the use-case of downloading many datasets via bacdive_ids is hampered by the fact that some have return Not found. Probably, because BacDive deleted them on their end and/or assigned them a different ID.

https://github.com/TIBHannover/BacDiveR/blob/77eba96265633d55c0284938ea1cccf2a4ffdddf/R/retrieve_data.R#L27-L32

could be changed to return a warning, an empty string, NULL, exactly Not found, etc. What would be most useful?

cc @jotech, @cameronmartino @ceb15: If you have an opinion or advice on this, it would be very welcome.