search

TIGER-NET / WOIS_installer

WOIS installer code
1 stars 2 forks source link

replace system bit option by auto detection #15

Closed j08lue closed 7 years ago

j08lue commented 8 years ago

Automatically detect whether the installer is for 32 bit or 64 bit by the existence of the folders "Installations_x32" and "Installations_x64", respectively. Remove drop-down option in welcome dialogue.

The option was obsolete because we distribute the two packages (32 bit and 64 bit) separately to reduce donwload size. Thereby, the user chooses the version already at download.

See also discussion at https://github.com/TIGER-NET/WOIS_Installer/commit/1f77901369df0b74d80679bd7af7adb0802571b8#commitcomment-19282307 .

We can merge this or keep it as separate branch. Preferences?

radosuav commented 8 years ago

Looks good and I would merge it if there are no plans to provide a combined installer in the future.

Just one comment, it might be good to make the error message (when neither directory exists) more visible to the user (e.g. something like here)

j08lue commented 8 years ago

Good point. I had added that RuntimeError only as a debugging error, not expecting the package to ever be incomplete. But now I turned it into a message box as you suggested (https://github.com/TIGER-NET/WOIS_Installer/pull/15/commits/2180d818d4f203eaa8bff2fd8946916175f819a4).