Closed jeanette-pelizzon closed 2 years ago
@LudmilaGoichman seems to me I put this issue in the wrong column. if you already tested it just move over.
@anvmn @jeanette-pelizzon
Results
:and this is relevant for the following tests:
Lab results are input as a numerical value (example: 105) Should only numbers without decimal digits be allowed?
999.888
^^, synced and opened the Content tab in the backend, I got the following error:and the result in the report was Results Missing
:
and the relevant node didn't contain the value at all:
and the test didn't appear in the subsequent encounter and in the results activity after this subsequent encounter:
and I got sync error on upload (the patient Cyiza Rose, Rwankuba HC):
but the report contains both values:
and now the env is stuck due to this error. @anvmn, could you please fix this?
sub-activity has been created
The Flow1 (with problems):
first encounter | case management | new sub-activity | only numbers can be entered | the result field is mandatory |
---|---|---|---|---|
The Flow2
first encounter | report before getting result | case management | the result | the report |
---|---|---|---|---|
@anvmn there is a small typo ("results") to change from point 1
The other findings seem sync related and maybe aren't issues at all, but can you investigate?
@adamhstewart
The problem is that we send Float value from client, while backend expect an Int. I think that sugar count does not have decimal, and we need to fix client side. Can you confirm please?
@anvmn checkec and confirmed mg/L should have no decimal. The backend wins.
"Result" is okay to use as it is individual inputs
On Tue, Jan 4, 2022 at 1:54 PM LudmilaGoichman @.***> wrote:
@anvmn https://github.com/anvmn @jeanette-pelizzon https://github.com/jeanette-pelizzon
- Nutrition Environment
- tablet
Questions/Found Issues:
- According to the design it should be Results:
[image: Test2_-_Google_Drive] https://user-images.githubusercontent.com/35059802/148104523-686dd5ba-5843-4ba3-99b1-c5fb0696e4b1.png
and this is relevant for the following tests:
- Blood Group + Rhesus Results
- Hemoglobin
- Urine Dipstick Example:
[image: 140399234-2baf951a-4233-4ea1-b01e-e064b84a537e_png364×696_] https://user-images.githubusercontent.com/35059802/148107316-f50c5ce4-a3a4-4a1a-af8b-c58e0ed32228.png [image: 148073893-bca463ea-629a-4a4d-bffe-18b5942aa30e_png726×1164_] https://user-images.githubusercontent.com/35059802/148107373-0823522c-2bae-47fb-a682-bc53025ca823.png
1.
Lab results are input as a numerical value (example: 105) Should only numbers without decimal digits be allowed?
[image: Test2_-_Google_Drive] https://user-images.githubusercontent.com/35059802/148104819-1a905f39-6594-4af8-b8a0-69c6d69576ee.png
- When I entered the result 999.888 ^^, synced and opened the Content tab in the backend, I got the following error:
[image: nutrition-ihangane_pantheonsite_io_says_and_Content_E-Heza_System_png] https://user-images.githubusercontent.com/35059802/148105236-49788a47-f131-48d8-85d6-0db25e31dcd4.png [image: nutrition-ihangane_pantheonsite_io_says_andContentE-Heza_System_png] https://user-images.githubusercontent.com/35059802/148105284-9f6add6b-bffb-4e7e-a679-6ed6ebfeb62c.png [image: nutrition-ihangane_pantheonsite_io_says_and_Content_E-Heza_System_png] https://user-images.githubusercontent.com/35059802/148105362-e4b79752-83cb-4e45-83ca-161e65ed3a4b.png [image: nutrition-ihangane_pantheonsite_io_says_andContentE-Heza_System_png] https://user-images.githubusercontent.com/35059802/148105392-0f3fc246-b9ff-4493-a2b5-2fd8a4685dcf.png
and the result in the report was Results Missing:
[image: Test2_-_Google_Drive] https://user-images.githubusercontent.com/35059802/148105663-50c30daf-5ee6-45b7-a63b-e8fbaa06f310.png
and the relevant node didn't contain the value at all:
[image: Test2_-_Google_Drive] https://user-images.githubusercontent.com/35059802/148105799-a14ea470-0b0b-4f35-881a-ce9cea21c345.png
and the test didn't appear in the subsequent encounter and in the results activity after this subsequent encounter: [image: Test2_-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148106469-069e3f2c-f45b-4fb9-ac23-c06be35e9be0.png [image: Test2-_Google_Drive] https://user-images.githubusercontent.com/35059802/148106587-cee6d76b-bab1-4f4b-8bf5-8d60d200d9db.png
- When I tried to reproduce the error from the previous point, I entered the following results:
[image: Test2_-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148108378-330b9ffe-8d73-40d2-96cc-1b5730e964c1.png [image: Test2-_Google_Drive] https://user-images.githubusercontent.com/35059802/148108408-e0fe86b1-bc93-4295-86a4-3ac7b59e6687.png
and I got sync error on upload (the patient Cyiza Rose, Rwankuba HC): [image: Test2_-_Google_Drive] https://user-images.githubusercontent.com/35059802/148108700-43037060-6443-40c7-a1c4-933271191ebf.png [image: Syncincident-Content_upload-_27f7b6fa-c50b-5c9d-b36a-fda8d48ef6ed___E-Heza_System] https://user-images.githubusercontent.com/35059802/148108939-b407040b-f692-46ec-be4d-fa91c05ee619.png
but the report contains both values:
[image: Test2_-_Google_Drive] https://user-images.githubusercontent.com/35059802/148108838-b5ffbb62-a77a-4ba7-a71e-c48c159aeb81.png
and now the env is stuck due to this error. @anvmn https://github.com/anvmn, could you please fix this? Checked and Approved
sub-activity has been created
The Flow1 (with problems): first encounter case management new sub-activity only numbers can be entered the result field is mandatory [image: Test2_-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148104304-54cd0b9b-4b67-4d47-89c0-1ae2db8bdde6.png [image: Test2-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148104337-66c5ee32-e74d-408d-8329-75ca878e40dd.png [image: Test2-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148104406-c6428d6c-28b6-418d-9a0a-31fc0ef0eec5.png [image: Test2-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148104583-fab8346f-de62-459a-b08a-6d26117ab9d6.png [image: Test2-_Google_Drive] https://user-images.githubusercontent.com/35059802/148104868-8d9f0ee5-e024-4d61-8ae9-6f73bc7ef6c0.png
The Flow2 first encounter report before getting result case management the result the report [image: Test2_-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148107641-8dc1c7e8-05b5-4d71-9fc4-3df95c72bbb0.png [image: Test2-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148107838-b8f118a0-c494-4d33-a495-c49151db0ae3.png [image: Test2-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148107932-4576f637-aa51-4c51-b6ff-a071ee48ff42.png [image: Test2-_GoogleDrive] https://user-images.githubusercontent.com/35059802/148108044-a01cd0c3-7553-4041-88ff-062668f59b83.png [image: Test2-_Google_Drive] https://user-images.githubusercontent.com/35059802/148108104-f2269992-de86-408d-b30d-607e8fec8776.png
— Reply to this email directly, view it on GitHub https://github.com/TIP-Global-Health/eheza-app/issues/67#issuecomment-1005084432, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASPKHOFMQ2WEK76A3UFJQDLUUM67RANCNFSM5KJNMBCQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
@adamhstewart
Issue is fixed at #99.
Since we use standard input (type=number
), we will not limit the decimals (though if there're no decimals), nurses should not be trying to enter any.
However, we will make sure that final value that is uploaded to backend is an Int.
@LudmilaGoichman deployed to Nutrition environment. Please test https://github.com/TIP-Global-Health/eheza-app/issues/67#issuecomment-1008932683
@isapisa
Before fixing | After fixing |
---|---|
final value that is uploaded to backend is an Integer. Examples:
@LudmilaGoichman
I do not think we should round anytrhing, because at real case scenario nurses will enter integer values for blood sugar.
Tested the 0, and I do see it on backend:
Can you recheck this please?
Issue
Overview During an ANC encounter, a patient sees a nurse who collects the appropriate samples for each test and then sends them to the lab (unless it is a rapid test). The samples are then processed by the lab and results are returned later that day. The patient will return to see the nurse after several hours and receive the results of the labs. Nurses will navigate from their Case Management screen to each patient awaiting lab results. The sub-activities will be all the tests that have been run but they do not yet have results for. The nurse will select the test she has results for and input them. She will do this for all tests she has results for. When she hits save that result will appear in the Progress Report for that patient.
Random Blood Sugar Specific Lab results are input as a numerical value (example: 105)
Note
You can see the Labs input screen issue for Random Blood Sugar here.
To Do