search

TIPOFF / bookings

Laravel Package for Ecommerce Bookings
MIT License
1 stars 1 forks source link

Omnia/feature/policies #21

Closed devjk1 closed 3 years ago

devjk1 commented 3 years ago

closes #11

Migration 'add bookings permissions' allows 4 permissions, including 'delete bookings' Test 'Permissions Migration Test' asserts 4 permissions

There were conflicting examples, so I opted to allow 'delete bookings' as standard. But I wanted to mention if this becomes an issue later.

drewroberts commented 3 years ago

For financial purposes, most of these models don't allow deletion

devjk1 commented 3 years ago

Booking model - generatePricing() throws Psalm error

Error: No return statements were found for method Tipoff\Bookings\Models\Booking::generatePricing but return type 'Tipoff\Bookings\Models\Booking' was expected Error: Process completed with exit code 2.