search

TIPOFF / bookings

Laravel Package for Ecommerce Bookings
MIT License
1 stars 1 forks source link

Require checkout package for order model reference during booking tab… #94

Closed kylebarney closed 3 years ago

kylebarney commented 3 years ago

…le migration

drewroberts commented 3 years ago

@pdbreen Can we require this for the time being and you work next week to separate out the dependency again?

pdbreen commented 3 years ago

The bookings table shouldn't have a FK to order - ie, remove this $table->foreignIdFor(app('order')); OrderItem has a morph relation to sellable (ie, a booking). Getting an OrderItem (and Order) from a booking should be via the inverse of the morph, not its own relation.

kylebarney commented 3 years ago

I opened a new PR to remove that relation: https://github.com/tipoff/bookings/pull/96