TIPOFF / laravel-serpapi

Laravel Package for wrapper of SerpApi
MIT License
0 stars 1 forks source link

SerpApiSearchException causes fatal PHP exceptions #5

Closed chx2 closed 3 years ago

chx2 commented 3 years ago

Currently, this package will trigger fatal PHP Execution errors. This is due to the SerpApiSearchException being instantiated within the SerpApiSearch package class. I think it may make better sense to refactor the exception into a separate file.

Screen Shot 2021-02-27 at 1 33 11 PM
arwaawan3 commented 3 years ago

@drewroberts @chx2 If this is resolved, can we close this issue?

chx2 commented 3 years ago

@arwaawan3 thanks!