Add factories - Githubissues

TIPOFF / seo

Laravel Package for tracking SEO keywords

MIT License

1 stars 0 forks source link

Add factories #52

Closed wolfrednicolas closed 3 years ago

wolfrednicolas commented 3 years ago

PlaceDetail
PlaceHour

wolfrednicolas commented 3 years ago

@pdbreen I have a question, I've seen this kind of issue in several packages, after check, I'm not able to understand what's going on... for example

this is the issue

Caused by Doctrine\DBAL\Driver\PDO\Exception: SQLSTATE[HY000]: General error: 1 no such table: domestic_addresses

Also I'm using the newest versions of the packages

pdbreen commented 3 years ago

Providers for package dependencies need to be added to the base TestCase getPackageProviders response. In this case, AddressesServiceProvider::class needed to be added.

https://github.com/tipoff/seo/blob/wolfrednicolas/feature/add-nova-resources/tests/TestCase.php

wolfrednicolas commented 3 years ago

thank you that work @pdbreen

wolfrednicolas commented 3 years ago

@drewroberts I think this is ready to merge, however; just one of the test is failing in the P7.4 - L8.* - prefer-lowest - ubuntu-lates