TISUnion / Carpet-TIS-Addition

A Carpet mod (fabric-carpet) extension, a collection of carpet mod style useful tools and interesting features
https://carpet.tis.world
GNU Lesser General Public License v3.0
271 stars 36 forks source link

Suggestion: add /place to the list of commands that get removed by opPlayerNoCheat rule #71

Closed nogutsnoglory69 closed 2 years ago

Fallen-Breath commented 2 years ago

What's the usage of that? Why did you choose the seem-to-be-irrelevant name /place.

Noted that /place is also a vanilla command, and the command list you want is shown in the description of the rule opPlayerNoCheat

nogutsnoglory69 commented 2 years ago

This rule is supposed to prevent accidental cheating, right? So to me it seems like that command should also be removed by that rule since it's very easy to autocomplete that command instead of /player.

If you don't want to hide that command through the opplayernocheat rule, may I suggest adding a seperate rule to disable that command? I just updated from 1.17 a few days ago and I keep autocompleting /place instead of the /player command all the time and it's very annoying.

Fallen-Breath commented 2 years ago

Ah you mean make the vanilla /place command disabled too. I thought you want to introduce a /place command to display what is disabled via the rule

Back to the suggestion itself, if there isn't any way to like one-key execute the /place command, I don't think it's necessary enough to disable the command just because it loves to pop up in other command suggestions. /place & /player is not the special case, since it still needs you to enter commands in your chatbar and press enter manually before executing the command. You can always accidentally execute much more commands if you don't check what you have input. If I did that people will keep asking me to add some other commands (maybe added by scarpet so the command name can be customized enough) to be disabled.

For the workaround, you can try tweakermore's prioritizedcommandsuggestions option to make the /player command is always on the top of the list

nogutsnoglory69 commented 2 years ago

I wasn't aware that tweakermore has that feature, I went ahead and enabled that. That does the job, thank you very much!