Showtime

[jamesdabbs]

Due on Mar 12 @ 10:00am Build a small but well-tested portion of a movie rental and streaming Rails app

Objectives

Learning Objectives

• Ensuring proper access controls to resources
• Writing tests to verify both functionality and security
• Familiarity with TDD'ing both high level features (/controllers) and units (/models)

  Performance Objectives

• Use cancancan to secure your app
• Use rspec, factory_girl, and spec helpers to TDD and build a robust spec suite

  Details

  Deliverables

A repo containing a Rails app with:

• Devise installed and configured
• a MoviesController with stream, checkout and checkin actions

  Requirements

• TDD it
• Running rspec should produce only passing specs

  Normal Mode

• "Streaming" or "checking out" can just return JSON with the movie title, description, etc.
• Users must be logged in to stream or checkout movies
• Users must be old enough to see the movie (based on their age and the movie's MPAA rating) to stream or check it out
• Users are only allowed to stream movies if their plan includes streaming
• Users are only allowed to check out a number of movies based on their plan
• There are tests verifying that the above features work
• Optional, but nice: install simplecov to verify your test coverage

  Hard Mode

Any of:

• Build out a view layer to interact with the controller (you may need to add other basic CRUD actions)
• Add a notion of "paid" accounts, and disallow viewing when the account is past due
• Set up TravisCI integration to check your tests and coverage

  Nightmare Mode

Any of:

• Pull movies from the Rotten Tomatoes API (e.g. recent releases)
• Integrate with e.g. Payola to take payments
• "stream" should send back a streaming response of e.g. the description

[msmukherji]

https://github.com/msmukherji/showtime-with-tests

(haven't done cancancan stuff yet)

[jamesdabbs]

Nice work, and excellent test coverage! :star2:

A few notes:

• This controller logic is functionally great, but I worry a bit about it not being factored out. I'd like to have one place responsible for handling "permission was denied" (ideally, raise an error and handle it in the ApplicationController) and one place responsible for handling "how do I display a move" (I usually use a jbuilder template, but pulling out a helper function on the controller is reasonable enough too).
• Just no. Replace that with

when "r", "nc-17", "unrated"
  age >= 17
when "pg-13"
  age >= 13
else
  true
end

In general, movie ratings seem like a good place to extract a value object

• Your user specs look good in general. I might pull out a decribe "underage users" block with a before(:each) { @user = create :user, age: 13 } to unify some of that common setup, but that's minor.
• plan isn't a great name for this field. It took me a minute (and reading the rest of the file) to decide if that was a plan number (like basic level: 3 movies) or just the number of movies you get.
• Are the UserMovie specs telling you anything that the User specs aren't? I don't feel like those are really adding anything.
• This is a nice thought. Rspec does have an expect { ... }.to change { user.moveis.count }.by 1 pattern, if you're in to that sort of thing.