TIY-LR-FEE-2015-Fall / assignments

1 stars 4 forks source link

05-Surf-and-Paddle - Chancey Ward #26

Open chanceyw opened 9 years ago

chanceyw commented 9 years ago
chanceyw commented 9 years ago

https://github.com/chanceyw/05-surf-and-paddle/pull/1

rtablada commented 9 years ago

@chanceyw a few things that I'm seeing so far that will help you out:

Not everything will need classes, things like your p tags for the meat of the article don't need to have a .content class. If anything grab the parent and style all the p tags within it.

Except for grids, try not to make your class names describe the styling of things classes and HTML in general should say WHAT the content is and think of it as the outline. With the same HTML, I should be able to make a new CSS stylesheet and make the site look very different but still have the same flow in terms of readability.

rtablada commented 9 years ago

@chanceyw don't set the width on your header, it should fill the full page width to the edge.

Otherwise, you should make your left and right columns grouped together in some div-like element.

Looks like you are using positioning a lot more than needed. Only use position when lining things up won't work. Right now as you add more content, you will have to keep going back to the styles to update them. Your layout and styles should continue working as more content is added to the page.

rtablada commented 8 years ago

The footer nav should be full width, we can look at this after the CSS and responsive review.