Open aliaborroho opened 9 years ago
@aliaborroho please publish on github pages using gh-page-deploy
and post a link here in the issue to your deployed clock.
@aliaborroho There are some weird things that I'm seeing in the code. We never looked at the onload
attribute in HTML elements and it is generally considered a bad practice.
We should be using window.setInterval
from our Javascript file and all scripting should be done in JS not in HTML.
There are also still some missing requirements:
I had my lessons and hw files jumbled together, that's not the one I intended to push, at the time I didn't have a good understanding of JavaScript or build tools, I will correct then mention you, please hold off on reviewing my work until I get my files in order, sorry for the mixup, driving right now, but I do recollect trying to remind myself to tell tell you to wait on the clock assignment, sorry
Alia Borroho Business Development
Phone: (501) 680-0116 Email: alia@apptegy.com Web: www.apptegy.com
On Jul 30, 2015, at 5:03 PM, Ryan Tablada notifications@github.com wrote:
@aliaborroho There are some weird things that I'm seeing in the code. We never looked at the onload attribute in HTML elements and it is generally considered a bad practice.
We should be using window.setInterval from our Javascript file and all scripting should be done in JS not in HTML.
There are also still some missing requirements:
Dynamically change the background color ever tick of a second — Reply to this email directly or view it on GitHub.
Deliverables
Requirements
console.log
the percentage of a minute that the current seconds represents (e.g., if 30 seconds have elapsed,console.log
0.5)console.log
a hexidecimal color that is based on the current second every second.radix
should = 16