TIY-LR-FEE-2015-June / assignments

0 stars 3 forks source link

3.3-clock-Alia Borroho #101

Open aliaborroho opened 9 years ago

aliaborroho commented 9 years ago

Deliverables

aliaborroho commented 9 years ago

https://github.com/aliaborroho/3.3-clock/pull/1

rtablada commented 9 years ago

@aliaborroho please publish on github pages using gh-page-deploy and post a link here in the issue to your deployed clock.

aliaborroho commented 9 years ago

http://aliaborroho.github.io/3.3-clock/

rtablada commented 9 years ago

@aliaborroho There are some weird things that I'm seeing in the code. We never looked at the onload attribute in HTML elements and it is generally considered a bad practice.

We should be using window.setInterval from our Javascript file and all scripting should be done in JS not in HTML.

There are also still some missing requirements:

aliaborroho commented 9 years ago

I had my lessons and hw files jumbled together, that's not the one I intended to push, at the time I didn't have a good understanding of JavaScript or build tools, I will correct then mention you, please hold off on reviewing my work until I get my files in order, sorry for the mixup, driving right now, but I do recollect trying to remind myself to tell tell you to wait on the clock assignment, sorry

Alia Borroho Business Development

Phone: (501) 680-0116 Email: alia@apptegy.com Web: www.apptegy.com

On Jul 30, 2015, at 5:03 PM, Ryan Tablada notifications@github.com wrote:

@aliaborroho There are some weird things that I'm seeing in the code. We never looked at the onload attribute in HTML elements and it is generally considered a bad practice.

We should be using window.setInterval from our Javascript file and all scripting should be done in JS not in HTML.

There are also still some missing requirements:

Dynamically change the background color ever tick of a second — Reply to this email directly or view it on GitHub.