1.2-layout-basic-Marvin Santiago

[marvinsantiago]

• [x] index.html Landing Page
• [x] styles/style.css css file linked from index.html
• [x] Page should have
  • [x] top image across the whole page
  • [x] badge on the left covering part of the top image
  • [x] multiple posts including different types of content using filler content
  • [x] heading text
  • [x] by line with author and date
  • [x] image
  • [x] lorem text after the image
• [x] Your HTML should pass in the HTML validator at https://html5.validator.nu/
• [x] Hard requirements
  • [x] Recreate the "Never miss a post section"
  • [ ] Should have an "x" in top right
  • [ ] Should stand off of the page visually
  • [ ] Should have image to the left of some stacked text
  • [ ] Should have colored button
• [x] Extra hard requirements
  • [x] Try building the left side bar where it says "the iron yard houston"

[marvinsantiago]

https://github.com/santiagomarvin/1.2---Layout---Basic/pull/2

[rtablada]

@santiagomarvin your columns look REALLY good and I like what you did with the search area.

The whole page seems to be stuck at 1250px wide though. I'm sure this is your laptop's regular size and we will be talking today about other screen sizes, but with full width let's try to keep things in percentages, then use px, once we are inside of our layout or for things like min-width.

[rtablada]

Also, I'm not sure why it's not showing up on the pull request for me to comment on, but line 50 has this HTML:

<img class="icon" src="http://31.media.tumblr.com/avatar_38a7797d5b04_64.png" alt"ironyard">

Notice that you forgot an = between alt and "ironyard".

Our new tools should catch issues like this from now on.

[marvinsantiago]

https://github.com/santiagomarvin/1.2-layout-basic/pull/3

[marvinsantiago]

https://github.com/santiagomarvin/1.2-layout-basic/pull/3

[rtablada]

@santiagomarvin better

There's still some weirdness with larger screen sizes, but I think we now have better tools to handle this. Don't worry about coming back to fix things but just thought I'd give you a heads up: