TIY-LR-FEE-2015-June / assignments

0 stars 3 forks source link

1.2 Basic Layout - Brent Thomas #16

Open Brent-M-Thomas opened 9 years ago

Brent-M-Thomas commented 9 years ago

Hard requirements

rtablada commented 9 years ago

@Brent-M-Thomas it looks like you may not have pushed your latest changes up to github (at least I think I remember you being farther than what I see right now).

The current spot that I am seeing:

screen shot 2015-07-06 at 7 21 37 am

On the header image, it is not spanning the full width of the page on larger screens and still has some room around the edge.

Your badge looks really good, and you have done some simple layout with the left and right columns. If you have the chance after finishing later homework try to go back and make the left column smaller and the right column centered on the page.

rtablada commented 9 years ago

@Brent-M-Thomas still needs some work on the header image and the two columns.

With the new tools we have I think the whole class is doing better with columns so I think we can get this to passing expectation.

You need to look at the top image and make sure it works it 100% width

rtablada commented 9 years ago

@Brent-M-Thomas Still missing a PR link

Brent-M-Thomas commented 9 years ago

Pull request @rtablada