2.3-photo-site-marvin-santiago

[marvinsantiago]

Deliverables

• [x] A repo containing at least:
  • [x] The default file structure
• [x] Multiple SCSS partials files
• [x] A centralized set of variables to allow changing the site theme (grid sizes, color scheme, etc)
• [x] Your site hosted on Github Pages
  • [x] Link to your Github pages in the Issue for this assignment

    Requirements

• [x] Your HTML and CSS should be valid.
  • [x] https://validator.w3.org/
  • [x] http://csslint.net/
• [x] Styling for:
  • [x] Photos
  • [x] Icons
  • [x] Photo information
  • [x] Title
  • [x] Date
  • [x] Camera Model
  • [x] Sensor Size
  • [x] f-stop
  • [x] ISO
  • [x] Shutter Speed
  • [x] Company Name About Image ("Landscape")
  • [x] Responsive Style on Desktop
  • [x] Photo Camera Info to the side of image
  • [x] Photo Title and Date Below Photo
  • [x] Hide Navbar Links On Mobile & Show Hamburger Icon
  • [x] Footer Section
  • [x] 2 wide photos with links and hover state
• [ ] Hard Mode Requirements:
  • [ ] Make the navbar shoot out from the side on mobile

[marvinsantiago]

https://github.com/santiagomarvin/2.3-photo-site/pull/1

[marvinsantiago]

https://github.com/santiagomarvin/2.3-photo-site/pull/1

[marvinsantiago]

https://github.com/santiagomarvin/2.3-photo-site/pull/1

[marvinsantiago]

https://github.com/santiagomarvin/2.3-photo-site/pull/1

Having issues with position under 1024px, my specs section (camera name/shutter speeds, etc). Its not wanting to shift down under the picture.

[rtablada]

@santiagomarvin only need one link to the PR. Also can you run gh-page-deploy so I can look at the site before pulling down code for general comments?

[marvinsantiago]

@rtablada sorry on the multiple PR links, got a little PR links trigger happy. i have ran gh-page-deploy per your request.

[rtablada]

@santiagomarvin

Comments

• I'm not seeing the text on top of the logo (maybe you're working on that now?)
• The bottom is nice and responsive and I see a media query for the top menu, but nothing so far on the photo and photo info?

I think your issue with the regular images and the specs could be solved by thinking of them more like a grid rather than position absolute.

Given a 12 col grid look at the shift function in Neat to help get the main image centered up and then specs should just be another column on the grid. I think from there it will make things a bit easier to work out?

[marvinsantiago]

@rtablada

-Text? are you referring to the 'Portraits' under the logo of the example?

• I will look into the 12 col grid......

[rtablada]

@santiagomarvin I have a lot of links to your github PR but no link to the site on gh pages?

[rtablada]

@santiagomarvin I'd like to see a bit of work go into the text and icons to make them feel a bit more "together". Right now they are out of line and the icons feel a bit small.

Also on the mobile view there's no room on the sides of the images so it feels a bit claustrophobic. Maybe some padding on your container at smaller screen sizes?

[marvinsantiago]

@rtablada I adjusted icons to same size of font in specs section, also adjusted line height between each line, added padding to the right for the icons. Also added padding to body when in mobile view.