2.3 - Photo Site - Jacklyn Carroll

[jacklynlee31]

Deliverables

• [x] A repo containing at least:
  • [x] The default file structure
• [x] Multiple SCSS partials files
• [x] A centralized set of variables to allow changing the site theme (grid sizes, color scheme, fonts, etc)
• [x] Your site hosted on Github Pages
  • [x] Link to your Github pages in the Issue for this assignment
• [x] At least one but no more than two Google Web Fonts

  Requirements

• [x] Your HTML and CSS should be valid.
  • [x] https://validator.w3.org/
  • [x] http://csslint.net/
• [x] Styling for:
  • [x] Photos
  • [x] Icons
  • [x] Photo information
  • [x] Title
  • [x] Date
  • [x] Camera Model
  • [x] Sensor Size
  • [x] f-stop
  • [x] ISO
  • [x] Shutter Speed
  • [x] Company Name Above Image ("Landscape")
  • [x] Responsive Style on Desktop
  • [x] Photo Camera Info to the side of image
  • [x] Photo Title and Date Below Photo
  • [ ] Hide Navbar Links On Mobile & Show Hamburger Icon
  • [x] Footer Section
  • [x] 2 wide photos with links and hover state
• [ ] Hard Mode Requirements:
  • [ ] Make the navbar shoot out from the side on mobile

[jacklynlee31]

https://github.com/jacklynlee31/2.3-photo-site/pull/1

[jacklynlee31]

GitHub Page: http://jacklynlee31.github.io/2.3-photo-site/

[rtablada]

@jacklynlee31

Comments

• Try putting your bottom area in a .row It seems weird for the content of the page to have two different max widths. If the content feels a bit squished try increasing your max width from 960px to 1140px
• Put your variables in a _variables.scss to accomplish the partial requirement

I have made further comments in the code of your pull request.

[rtablada]

@jacklynlee31 looks pretty good.

The logo gets a bit strange on smaller screens and phones. Centering can be tough. Also missing the menu icon when on phone screens. It doesn't need to show a full responsive menu but I think you can get it to show and hide just this icon.