search

TKFRvisionOfficial / bszet_substitution_plan

Parsing and Image creation service of the BSZET substitution plan bot
GNU Affero General Public License v3.0
2 stars 0 forks source link

Archiving plan for every date independent #34

Closed TKFRvisionOfficial closed 2 years ago

TKFRvisionOfficial commented 2 years ago

can y'all stop being so obnoxious now? thanks...

this is not tested. don't merge yet

TKFRvisionOfficial commented 2 years ago

Also I want to mention because you guys wanted it so badly and quickly we now have a circle reference between pdf_parsing.py and util.py. We need to throw all the parsing functions into its own file and only keep the main function in pdf_parsing in the future...

TKFRvisionOfficial commented 2 years ago

Also I'm not sure about the response codes. They need to be changed probably. Maybe a json api would be better...

MarcelCoding commented 2 years ago

Also I want to mention because you guys wanted it so badly and quickly we now have a circle reference between pdf_parsing.py and util.py. We need to throw all the parsing functions into its own file and only keep the main function in pdf_parsing in the future...

How about a draft?

TKFRvisionOfficial commented 2 years ago

yeah good idea but i can't see the button to do that

TKFRvisionOfficial commented 2 years ago

seems like that option is not avalaible on private repos if you're not on a team plan. Github Pro is nothing you can buy anymore. It got deprecated in favor of the team plans. Sadly on GitHub Student you only get that legacy pro plan which doesen't has access to the new features...

TKFRvisionOfficial commented 2 years ago

alright another problem is that currently im storing the substitution plan of the current day. but often in the evening the plan dosen't even contain the current day anymore resulting in an error. but if we parse the next day we will have to keep track of weekends and such...there must be an easier solution to this...