search

TKMM-Team / Tkmm

A mod merger and manager for Tears of the kingdom
https://tkmm.org
MIT License
46 stars 8 forks source link

[Bug] TotK-RstbCalculator does not reset the cached vanilla RSTB file when changing the dump version #22

Closed MasterBubbles closed 3 months ago

MasterBubbles commented 3 months ago

When changing the game path setting to a different dump version and clicking save, TotK-RstbCalculator will keep the vanilla RSTB file from the previous dump in cache, and merging will continue to generate a resource table for the previous version (until closing and reopening TKMM)

ArchLeaders commented 3 months ago

The vanilla file is parsed every time a new RstbGenerator is constructed. Can you provide steps to create and verify that this is occurring?

MasterBubbles commented 3 months ago

Open TKMM, merge a first time, go to the settings, change the dump location to a different version of the game, then merge a second time. The second time it merges, it will still use the previous version for the resource table. RSDB files on the other hand are correct

ArchLeaders commented 3 months ago

Fixed in https://github.com/TKMM-Team/Tkmm/commit/f68c4c166de134badebf134f098eddc2d30985a9