search

TKOaly / exam-archive-new

New exam archive ("Tärpistö") of TKO-äly ry
https://tarpisto.tko-aly.fi
MIT License
0 stars 3 forks source link

Replaced JavaScript service worker with TypeScript service worker #3

Closed alehuo closed 5 years ago

alehuo commented 5 years ago

Replaced JavaScript service worker with TypeScript service worker. Updated index.tsx to reflect this change. Let's unregister the service worker as default.

strax commented 5 years ago

Do we even need the file if we’re just deregistering the SW? I mean why not just delete the whole functionality since this is not in production?

alehuo commented 5 years ago

We can either delete the functionality as a whole, or unregister it. I think it's up to the fact if we need a service worker sometime in the future.

Service worker is opt-in starting from CRA 2.0.

strax commented 5 years ago

We can always add the SW back if we need it, I think this is analogous to commenting out code to preserve it for the future which is unnecessary with git.

cxcorp commented 5 years ago

Gonna delete the service worker.