search

TLeconte / vdlm2dec

vdl mode 2 SDR decoder
GNU General Public License v2.0
71 stars 23 forks source link

Expand ID string to 32 chars (vdlm2dec) #40

Closed TanerH closed 4 years ago

TanerH commented 4 years ago

Hi, (Same message for both acarsdec and vdlm2dec(THIS))

In both vdl2mdec and acarsdec, there is a "station ID". acarsdec has it limited to 8 characters, and vdlm2dec doesn't have a limit. I'm proposing bringing these in line together, at 32 characters. (Also, this fixes a bug in acarsdec that is missing a free() before re-assigning idstation via cmdline arg.)

NOTE: acarsserv would also need to be modified to allow up to 32 chars for the station ID.

-Taner

kevinelliott commented 4 years ago

@TLeconte Any update on this?

kevinelliott commented 4 years ago

@TanerH Can you make this 36 characters please? I'd like for it to be able to store UUID and 32 is not long enough.

Section 3 of RFC4122 provides the formal definition of UUID string representations. It's 36 characters (32 hex digits + 4 dashes).
TanerH commented 4 years ago

I've changed my branch to use a #define (in vdlm2.h) and it's now default to 48

kevinelliott commented 4 years ago

@TanerH You da man! 🥳

kevinelliott commented 4 years ago

@TanerH Can you apply the same for https://github.com/TLeconte/acarsdec ?