search

TLeonardUK / ds3os

Dark Souls - Open Server
MIT License
700 stars 113 forks source link

subtle bug in class NetIPAddress #166

Closed KeithCoreDumped closed 1 year ago

KeithCoreDumped commented 2 years ago

in https://github.com/TLeonardUK/ds3os/blob/4f3c12e7dc21faebcaaebe680b3b48b2247943ea/Source/Server/Core/Network/NetIPAddress.h#L22 there are some typos in subscripts:

Bytes[0] = 127;
Bytes[0] = 0;
Bytes[0] = 0;
Bytes[0] = 1;

should be:

Bytes[0] = 127;
Bytes[1] = 0;
Bytes[2] = 0;
Bytes[3] = 1;

Though it may not cause problems, for now, it might bring about some difficulty in debugging someday if the default constructor is invoked. Thanks for your awesome work by the way.

TLeonardUK commented 2 years ago

Good catch. It shouldn't cause any issue as nothing should rely on the default value of it, but I'll fix it anyway!

TLeonardUK commented 1 year ago

Very late fix, but resolved ...