TMElyralab / Comfyui-MusePose

Other
287 stars 28 forks source link

requirements.txt Is it reasonable? #4

Closed hben35096 closed 1 month ago

hben35096 commented 1 month ago

one of them torch==2.0.1 Will this have a big impact on the ComfyUI running environment? Many people's running environment is Torch: 2.1.1

lulu-xiao commented 1 month ago

thanks for the comment. I tried and it works in torch 2.1.1. Also I modified the version restrictions of torch and xformer. you can have a try.

laidingq commented 1 month ago

最重要的是diffusers的限制会和很多插件不兼容

lulu-xiao commented 1 month ago

最重要的是diffusers的限制会和很多插件不兼容

确实目前要求0.24.0的版本,是有点低了,后续我们看看是否可以升级下

JPW0080 commented 1 month ago

On my side, it worked on Win 11 with Torch 2.2.2+cu121: Unfortunately, diffusers==0.24.0 requirement did not agree with some Nodes.

ComfyUI-MusePose-Torch-2-2-2+cu121

ComfyUI-MusePose-Torch-2-2-2+cu121-xfomers

FAILED IMPORT:

ComfyUI-Geowizard ComfyUI-BrushNet ComfyUI-layerdiffusion ComfyUI-J ComfyUI-ADMotionDirector

With luck, most of the other requirements should already be satisfied.

After cloning, Backup and Delete everything within \ComfyUI\custom_nodes\Comfyui-MusePose\requirements.txt The requiremnets.txt should now be empty...

Activate ComfyUI ENV

pip install diffusers==0.24.0 pip install openmim mim install mmengine mim install "mmcv==2.1.0" mim install "mmdet==3.2.0" mim install "mmpose==1.3.1"

Launch ComfyUI and Test the provided musepose-workflow-demo workflow

If errors, refer to the backup of \ComfyUI\custom_nodes\Comfyui-MusePose\requirements.txt Avoid anything Torch, xformers related.

Activate ComfyUI ENV and install missing requirements, like so pip install av==11.0

Revert Diffusers Example

Activate ComfyUI ENV pip install diffusers==0.27.2

OFFLINE diffusers Example

Download .whl https://pypi.org/project/diffusers/0.24.0/#files https://pypi.org/project/diffusers/0.27.2/#files

Place the diffusers .whls into something like \ComfyUI\whls

Activate ComfyUI ENV cd \ComfyUI

pip install ./whls/diffusers-0.24.0-py3-none-any.whl

Revert diffusers OFFLINE

Activate ComfyUI ENV cd \ComfyUI

pip install ./whls/diffusers-0.27.2-py3-none-any.whl

Pythonpa commented 1 month ago

最重要的是diffusers的限制会和很多插件不兼容

确实目前要求0.24.0的版本,是有点低了,后续我们看看是否可以升级下

对,这个版本确实有点低了,我目前想了一个临时解决办法,让diffusers==0.27.2也能先跑起来,虽然暂时没出现什么问题,但是如果官方能把这个依赖版本升高一点,当然最好。 image

Quasimondo commented 1 month ago

Generally it would be nice if you could loosen some of those requirements and at least replace the == with >= - I understand that these are the versions which worked for you, but in practice most of the time those strict versions are not necessary and they tend to mess with other custom nodes that have to use the same system.

Quasimondo commented 1 month ago

Just in case it is interesting for others - I am able to run this without having to adhere to the strict version numbers - I removed all the == from the requirements.txt, so my file looks like this:

einops
imageio
imageio-ffmpeg
omegaconf
opencv-contrib-python
opencv-python
scikit-image
scikit-learn
transformers
mlflow
moviepy
urllib3
torch
torchdiffeq
torchmetrics
torchsde
torchvision
accelerate
av
clip
decord
diffusers
open-clip-torch
xformers

The only problem that occured is that two classes have been renamed in the newer diffusers library, but I was able to fix this by patching two files:

in unet_2d_condition.py: replace all occurrences of "PositionNet" with "GLIGENTextBoundingboxProjection"

in transformer_2d.py: replace all occurrences of "CaptionProjection" with "PixArtAlphaTextProjection"

lulu-xiao commented 1 month ago

最重要的是diffusers的限制会和很多插件不兼容

确实目前要求0.24.0的版本,是有点低了,后续我们看看是否可以升级下

对,这个版本确实有点低了,我目前想了一个临时解决办法,让diffusers==0.27.2也能先跑起来,虽然暂时没出现什么问题,但是如果官方能把这个依赖版本升高一点,当然最好。 image

diffusers 0.27.2 is now suported!

lulu-xiao commented 1 month ago

On my side, it worked on Win 11 with Torch 2.2.2+cu121: Unfortunately, diffusers==0.24.0 requirement did not agree with some Nodes.

ComfyUI-MusePose-Torch-2-2-2+cu121

ComfyUI-MusePose-Torch-2-2-2+cu121-xfomers

FAILED IMPORT:

ComfyUI-Geowizard ComfyUI-BrushNet ComfyUI-layerdiffusion ComfyUI-J ComfyUI-ADMotionDirector

With luck, most of the other requirements should already be satisfied.

After cloning, Backup and Delete everything within \ComfyUI\custom_nodes\Comfyui-MusePose\requirements.txt The requiremnets.txt should now be empty...

Activate ComfyUI ENV

pip install diffusers==0.24.0 pip install openmim mim install mmengine mim install "mmcv==2.1.0" mim install "mmdet==3.2.0" mim install "mmpose==1.3.1"

Launch ComfyUI and Test the provided musepose-workflow-demo workflow

If errors, refer to the backup of \ComfyUI\custom_nodes\Comfyui-MusePose\requirements.txt Avoid anything Torch, xformers related.

Activate ComfyUI ENV and install missing requirements, like so pip install av==11.0

Revert Diffusers Example

Activate ComfyUI ENV pip install diffusers==0.27.2

OFFLINE diffusers Example

Download .whl https://pypi.org/project/diffusers/0.24.0/#files https://pypi.org/project/diffusers/0.27.2/#files

Place the diffusers .whls into something like \ComfyUI\whls

Activate ComfyUI ENV cd \ComfyUI

pip install ./whls/diffusers-0.24.0-py3-none-any.whl

Revert diffusers OFFLINE

Activate ComfyUI ENV cd \ComfyUI

pip install ./whls/diffusers-0.27.2-py3-none-any.whl

lulu-xiao commented 1 month ago

最重要的是diffusers的限制会和很多插件不兼容

diffusers 0.27.2 is now suported

laidingq commented 1 month ago

最重要的是diffusers的限制会和很多插件不兼容

diffusers 0.27.2 is now suported

已加载成功,谢谢