Closed Airblader closed 5 years ago
Merging #105 into master will increase coverage by
0.62%
. The diff coverage is95.38%
.
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 83.96% 84.59% +0.62%
==========================================
Files 25 25
Lines 655 675 +20
Branches 99 104 +5
==========================================
+ Hits 550 571 +21
+ Misses 52 51 -1
Partials 53 53
Impacted Files | Coverage Δ | |
---|---|---|
projects/ngqp/core/src/lib/serializers.ts | 66.66% <ø> (-3.34%) |
:arrow_down: |
...re/src/lib/directives/query-param-group.service.ts | 83.6% <100%> (-0.49%) |
:arrow_down: |
...jects/ngqp/core/src/lib/model/query-param-group.ts | 98.07% <100%> (ø) |
:arrow_up: |
projects/ngqp/core/src/lib/model/query-param.ts | 93.84% <93.54%> (+0.36%) |
:arrow_up: |
...s/ngqp/core/src/lib/query-param-builder.service.ts | 96.66% <95.45%> (+2.54%) |
:arrow_up: |
...s/multi-select-control-value-accessor.directive.ts | 85.71% <0%> (+2.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c0c36ce...0e28c35. Read the comment docs.
This change improves the type safety by not misinterpreting an array-valued parameter as a multi: true parameter.
As a side effect we can now support emptyOn for multi: true parameters.
fixes #92 fixes #27
Signed-off-by: Ingo Bürk ingo.buerk@tngtech.com
I have verified that…