TNG / ngqp

Declaratively synchronize form controls with the URL
https://tng.github.io/ngqp
MIT License
81 stars 8 forks source link

#120: Call setParent(null) when removing a param from a group #125

Closed Airblader closed 5 years ago

Airblader commented 5 years ago

This pull request relates to or closes the following issues:

I have verified that…

codecov[bot] commented 5 years ago

Codecov Report

Merging #125 into master will increase coverage by 0.06%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   85.29%   85.35%   +0.06%     
==========================================
  Files          25       25              
  Lines         721      724       +3     
  Branches      111      111              
==========================================
+ Hits          615      618       +3     
  Misses         51       51              
  Partials       55       55
Impacted Files Coverage Δ
...jects/ngqp/core/src/lib/model/query-param-group.ts 98.14% <100%> (+0.07%) :arrow_up:
projects/ngqp/core/src/lib/model/query-param.ts 93.33% <50%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 134acd0...b70262e. Read the comment docs.