TNG / ngqp

Declaratively synchronize form controls with the URL
https://tng.github.io/ngqp
MIT License
81 stars 8 forks source link

feat(core): support asynchronous deserializers #131

Closed Airblader closed 5 years ago

Airblader commented 5 years ago

relates #93

This is a work in progress following a quick proof of concept. Open points I need to work on:

This pull request relates to or closes the following issues:

I have verified that…

codecov[bot] commented 5 years ago

Codecov Report

Merging #131 into master will increase coverage by 0.16%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage    84.6%   84.77%   +0.16%     
==========================================
  Files          25       25              
  Lines         734      742       +8     
  Branches      115      117       +2     
==========================================
+ Hits          621      629       +8     
  Misses         54       54              
  Partials       59       59
Impacted Files Coverage Δ
projects/ngqp/core/src/lib/util.ts 95% <100%> (+0.4%) :arrow_up:
projects/ngqp/core/src/lib/model/query-param.ts 91.2% <75%> (+0.09%) :arrow_up:
...re/src/lib/directives/query-param-group.service.ts 84.31% <93.75%> (-0.26%) :arrow_down:
...s/multi-select-control-value-accessor.directive.ts 87.75% <0%> (+2.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fb8ed5...428e266. Read the comment docs.