Closed Airblader closed 4 years ago
Description | Example fixes |
---|---|
'public' is implicit. Occurrences: | :wrench: Example fixes |
No catch method for promise. This may result in an unhandled promise rejection. Occurrences: | :wrench: Example fixes |
Merging #174 into master will increase coverage by
0.03%
. The diff coverage is83.33%
.
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 84.00% 84.04% +0.03%
==========================================
Files 25 25
Lines 744 752 +8
Branches 118 119 +1
==========================================
+ Hits 625 632 +7
Misses 60 60
- Partials 59 60 +1
Impacted Files | Coverage Δ | |
---|---|---|
...re/src/lib/directives/query-param-group.service.ts | 84.37% <77.77%> (+0.06%) |
:arrow_up: |
...jects/ngqp/core/src/lib/model/query-param-group.ts | 98.18% <100.00%> (+0.03%) |
:arrow_up: |
...s/ngqp/core/src/lib/query-param-builder.service.ts | 96.87% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1c71733...93d056f. Read the comment docs.
When set, the query params managed by the QueryParamGroup are cleared from the URL when the directive binding this group goes out of scope.
fixes #172
Signed-off-by: Ingo Bürk ingo.buerk@tngtech.com
This pull request relates to or closes the following issues:
I have verified that…