Closed ringogroenewegen closed 1 week ago
✅ You wrote maintainable code and achieved your Sigrid objective of 3.5 stars
Sigrid compared your code against the baseline of 2024-10-18.
You fixed or improved 0 refactoring candidates.
Unfortunately, 1 refactoring candidates were introduced or got worse.
Risk | System property | Location |
---|---|---|
🔴 | Duplication (Introduced) |
WuppieFuzz/src/input/method.rs (lines 148-154) WuppieFuzz/src/input/method.rs (lines 159-165) |
0 refactoring candidates didn't get better or worse, but are still present in the code you touched.
System property | System on 2024-10-18 | Before changes | New/changed code |
---|---|---|---|
Volume | 5.4 | N/A | N/A |
Duplication | 3.9 | 3.4 | 3.6 |
Unit Size | 2.1 | 5.5 | 5.5 |
Unit Complexity | 2.9 | 5.5 | 5.5 |
Unit Interfacing | 2.0 | 5.5 | 5.5 |
Module Coupling | 3.3 | N/A | N/A |
Component Independence | 5.4 | N/A | N/A |
Component Entanglement | N/A | N/A | N/A |
Maintainability | 3.6 | 4.9 | 5.0 |
We would like to know your thoughts to make Sigrid better. Your username will remain confidential throughout the process.
Looks good, can you add a changelog entry in CHANGELOG.md
?
Looks good, can you add a changelog entry in
CHANGELOG.md
?
Done!
Two HTTP methods were missing: Options and Connect. These are now added to prevent the fuzzer from crashing when encountering these in an OpenAPI spec