TNO / Rejuvenation-Ada

Analysis and manipulation of Ada software based on concrete syntax
BSD 3-Clause "New" or "Revised" License
22 stars 1 forks source link

Test case not robust for platform changes #12

Closed pjljvandelaar closed 2 years ago

pjljvandelaar commented 2 years ago

See https://github.com/TNO/Rejuvenation-Ada/runs/8209574739?check_suite_focus=true

In workshop (ubuntu-latest), a test case fails with

FAIL Workshop Examples : Units - withed / imported
    Length of Unit Dependencies is unexpectedly not 17 but  16
    at test_examples.adb:325

The number of dependencies is indeed currently, hard coded.

Should be made more flexible to handle gnat 11 and 12 with a single test case!

pjljvandelaar commented 2 years ago

The not-robust code is https://github.com/TNO/Rejuvenation-Ada/blob/555c5539586d129cd4fcb10f0c1e456dc16a59a7/workshop/tests/src/test_examples.adb#L325-L329

pjljvandelaar commented 2 years ago

Fixed by number of commits including https://github.com/TNO/Rejuvenation-Ada/commit/b4bd6b617f180724aece385d122f08d720d55157