search

TNO / knowledge-engine

Improves interoperability between systems (i.e. devices, platforms, apps, databases) by exchanging data based on their semantics
https://knowledge-engine.eu
Apache License 2.0
33 stars 4 forks source link

RecipientSelector should support multiple Knowledge Bases #388

Closed Sophietje closed 10 months ago

Sophietje commented 2 years ago

In GitLab by @han.kruiger.tno.nl on Jun 20, 2022, 11:40

Sophietje commented 2 years ago

In GitLab by @sylvain.rival.gfi.world on Jul 7, 2022, 13:26

We experience the same issue in the scope of the french pilot.

Enedis has a service that send an alarm when energy consumption at household level is greater than the subscribed power. This alarm must be catched by a service that manage the equipement in order to reduce consumption and a second service that store the alarm for KPI purpose. As we take care of GPDR, the POST is in the context of the recipient selector. Does the KE in the scope of recipient selector feature support multiple knowledge bases ? Thanks for your help, Sylvain

Sophietje commented 2 years ago

In GitLab by @barry.nouwt.tno.nl on Aug 26, 2022, 07:36

This issue requires a REST API change. We discussed to add a new JSON field called knowledgeBases inside the recipientSelector's JSON object (of the /sc/ask and /sc/post operations) to support multiple recipient KBs. We will deprecate the singleKnowledgeBase field, but leave it in the API to stay backwards compatible.

Sophietje commented 2 years ago

In GitLab by @han.kruiger.tno.nl on Aug 26, 2022, 12:03

created branch 374-recipientselector-should-support-multiple-knowledge-bases to address this issue

Sophietje commented 2 years ago

In GitLab by @sylvain.rival.gfi.world on Aug 26, 2022, 12:43

As in the Service Store you need to onboard the service to whom you want to send data and wait for the approval we were planning to onboard 2x services but this is not a solution as a REST API change is under consideration. Which component will be impacted ? The KE ? the GA ? Thanks to have taken this request into account.

Sophietje commented 2 years ago

In GitLab by @han.kruiger.tno.nl on Aug 26, 2022, 14:04

mentioned in commit 12de02fe6fd8737521e9bfaae7c2894a876980d0

Sophietje commented 2 years ago

In GitLab by @han.kruiger.tno.nl on Aug 26, 2022, 14:28

The KE will (in the next release) have an additional feature in its API, and the existing functionality will be unaffected. For partners using the KE directly, it will be possible to use the RecipientSelector to select multiple recipients now. The KE REST API documentation now includes some documentation on how to use this: https://gitlab.inesctec.pt/interconnect/knowledge-engine/-/blob/master/smart-connector-rest-server/src/main/resources/openapi-sc.yaml#/proactive/post_sc_ask (specifically, look for the examples in the proactive routes)

The GA can use this feature to more easily integrate with this functionality, perhaps also providing more functionality, but that is up to the GA developers.