TNRIS / data.tnris.org-svelte

MIT License
3 stars 0 forks source link

Imagery WMS link are incorrect #46

Open mitchellryant opened 6 months ago

mitchellryant commented 6 months ago

Imagery WMS link are incorrect, adding /rest/ to URL.

image image

not sure if this is related to any updates to API or anything else.

mitchellryant commented 6 months ago

links Feature based WMS services are good! no issues!

image

csidenblad commented 6 months ago

Levi and Chris were able to locate where the issue was in the javascript, but it looks like the wms links within the API are not correct or do not have the correct permissions.

image

L-Har commented 6 months ago

This is the relevant source code causing this issue.

image

L-Har commented 6 months ago

I'm going to hold off on removing this until you guys give me the go ahead. @csidenblad @mitchellryant

mitchellryant commented 6 months ago

@L-Har @ctrepka

A WMS link from AGS are not REST service, they are not publish via a REST endpoint. image

https://imagery.geographic.texas.gov/server/services/NAIP/NAIP22_NCCIR_60cm/ImageServer/WMSServer?request=GetCapabilities&service=WMS - will return with the Capabilities of the service in a browser.

No web browser can "parse" and\or return correctly any WMServer link without ?request=GetCapabilities&service=WMS it will just error out.

In Pro, Desktop, Global Mapper, QGIS, & etc. you do not need anything after the "?', which is URL in the API. https://imagery.geographic.texas.gov/server/services/NAIP/NAIP22_NCCIR_60cm/ImageServer/WMSServer

Without /rest/ image

with /rest/ image

the front end should just show the value of the wms_link field from the API. no /rest/. image

the popup_link field uses the Java Script API in the REST endpoint. image

https://imagery.geographic.texas.gov/server/rest/services/NAIP/NAIP22_NCCIR_60cm/ImageServer shows all the working URLs related to this service

if you go with the values in the wms_link field, you might just place it on the front end as text and not a href. so no one clicks to an error.

all the WMS links in the API have been updated to reflect the new domains.