search

TNRIS / dataHub

ReactJS frontend web application for browsing, downloading, and inquiring about TNRIS public data and historical imagery.
https://data.tnris.org
7 stars 0 forks source link

lost filter when clicking DataHub home link from collection #212

Closed jwhaney closed 4 years ago

jwhaney commented 4 years ago

to reproduce this bug:

  1. add availability filter --> External Link
  2. add category filter --> Hydrography
  3. visit one of the collections
  4. in the top left next to the search bar, click the DataHub home link

the results now only show External Link filtered collections, but not Hydrography. if you follow these same steps but instead of clicking the DataHub link, click the browser back button, all filters are still applied.

jwhaney commented 4 years ago

upon discussion with @JasonKleinert, this bug only occurs if you involve the browser back button. if the user only clicks the home dataHub button which runs handleCatalogView (setViewCatalog and setUrl), then there are no lost filters.

this still needs to be investigated in my opinion in the future.

jwhaney commented 4 years ago

can no longer reproduce this error. the 'home' button in the top left of a collection view does not exist any longer since we removed that portion of the header. also, regarding the back button, no filters are lost when going back from a collection view using the browser back button.

closing - cant reproduce.