search

TNRIS / dataHub

ReactJS frontend web application for browsing, downloading, and inquiring about TNRIS public data and historical imagery.
https://data.tnris.org
8 stars 0 forks source link

Feature/services filter #221

Closed jwhaney closed 5 years ago

jwhaney commented 5 years ago

what is this? this is a new Availability - WMS_Service collection filter in the tool drawer.

methodology I manually fudged in the input checkbox html in the collectionFilter component feeding it the same capabilities/functions as the other automatically created filter input checkboxes below this one. then in the collectionSelectors, the getFilteredCollections method handles the logic to specifically check for the 'WMS_Service' filter being set first, and then checks for all collection ids with a valid wms_link property before adding those collection ids to the filteredCollectionIds or multiFilteredCollectionIds array.

i need this one tested out pretty good before we merge it. i've run through it a couple dozen times and it seems to behave properly but i want to make sure its solid.

there is probably a better way to do this and i'm open to suggestions for ways to re-factor or change this functionality. its seems to work pretty good though I think. take a look and let me know what yall think. we can push new commits and change this if you guys think we should. whatever works best.

thanks.

jwhaney commented 5 years ago

oh, one note. if you set the Download filter and then set the new __WMS_Service filter, there isn't a change in the number of collections because all collections with wms services are available for download. there may be a valid point to put this filter somewhere else other than within the Availability__ filters. I don't know...

jwhaney commented 5 years ago

bump