Creating Survey Modal components to facilitate survey submissions to API endpoint

TNRIS / dataHub

ReactJS frontend web application for browsing, downloading, and inquiring about TNRIS public data and historical imagery.

https://data.tnris.org

8 stars 0 forks source link

Creating Survey Modal components to facilitate survey submissions to API endpoint #284

Closed ctrepka closed 4 years ago

ctrepka commented 4 years ago

Implements Survey Modal components to facilitate survey submissions to API endpoint related to Issue #279

ctrepka commented 4 years ago

i like how you utilized the standard api response "results" array and put it directly into the reducer, as-is, and as the same type without doing any manipulation or analyzing of the content within. i found just a few minor code standard stuff that needs cleanup before we merge this over

Thanks, just resolved those issues, should be ready to go if it all looks good

ctrepka commented 4 years ago

i like how you utilized the standard api response "results" array and put it directly into the reducer, as-is, and as the same type without doing any manipulation or analyzing of the content within.

Wait was this sarcasm? Sorry, not coming thru on a screen well if it was, but is this something I should fix or is it actually desirable as a practice?