TOGoS / TMCMR

TOGoS's Minecraft Map Renderer
http://www.nuke24.net/projects/TMCMR/
Other
45 stars 18 forks source link

tiles.html file is infinitely generated #11

Closed tobast closed 10 years ago

tobast commented 11 years ago

Hello, I've spotted a "bug", which may or may not be considered as one: when your map is discontinued, the "tiles.html" file will grow up really quickly, filled up only with [] (repeat the hooked part a lot, one line represents 516Ko for me). The reason is, I think, the fact that one day an admin on my server misused the /tp command to teleport himself really far (I have a tile generated at -58594.-58594, where the "legit" farest is -3.-6). This way, I believe that the code tries to generate a large amount of empty lines to fill up the space between discontinued tiles, but it has already generated a 6.0Go file here, so I killed the process.

A better way wouldn't be to draw a line with "…" or whatever to link discontinue areas?

Tobast

TOGoS commented 11 years ago

I have a map like that on my server, too. Actually I would say there are several issues, here:

1) There's no option to skip empty rows/columns.

2) Empty rows/columns are generated but not explicitly sized so get squished by the browser (so even if you wanted them to show up, they don't appear correctly)

3) A big HTML table of images isn't a scalable solution :P

A simple solution to (1) involving a couple of HashSets should be fairly easy to implement. I may get to that sometime in the next few days.

TOGoS commented 10 years ago

You can now work around this by limiting the area processed with: -region-limit-rect <x0> <y0> <x1> <y1>