Biome & Block errors debug

[uncovery]

It would be great if the debug option could list all instances where the mapper fell back to the default colors to better be able to trace the source of pink blocks. I still have some and no idea how to fix them.

[TOGoS]

I've added this and made a new JAR: http://pix.nuke24.net/uri-res/raw/urn:bitprint:MLFJFTMYBO4J3SMPCUV5J6GSNWZCOSSW.JATIZF7XHC234MAM524JVLQ2H2NIYCPTGNXGESI/TMCMR-2013.12.15a.jar

[uncovery]

Thanks a lot!

I am getting this here:

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: -89 at togos.minecraft.maprend.BiomeMap.getBiome(BiomeMap.java:101) at togos.minecraft.maprend.RegionRenderer.getColor(RegionRenderer.java:168) at togos.minecraft.maprend.RegionRenderer.preRender(RegionRenderer.java:264) at togos.minecraft.maprend.RegionRenderer.render(RegionRenderer.java:305) at togos.minecraft.maprend.RegionRenderer.renderAll(RegionRenderer.java:357) at togos.minecraft.maprend.RegionRenderer$RegionRendererCommand.run(RegionRenderer.java:545) at togos.minecraft.maprend.RegionRenderer.main(RegionRenderer.java:595)

[TOGoS]

Fixed. There was a || in a range check that should've been a &&. http://pix.nuke24.net/uri-res/raw/urn:bitprint:5OZURKHS4YUAAE46FBABEJ3IPU5JQ7QN.CSRBFCGTRNUJSNGP6ATQFFFDF4RBAWPS6XWF67A/TMCMR-2013.12.15b.jar

[uncovery]

Thanks a lot. I managed to fix the block codes now. With the Biome codes there seems to be an issue. I have all the biome codes in the system, however, those here are reported to be missing:

0xFFFFFF81 0xFFFFFF82 0xFFFFFF83 0xFFFFFF84 0xFFFFFF9C 0xFFFFFF9D 0xFFFFFFA3 0xFFFFFFA4 0xFFFFFFA5 0xFFFFFFA6 0xFFFFFFA7

Accordingly, the areas where those are present, are pink. However, they ARE in the config file:

0x81 0xFF536B33 0xFF4F7020 0xFF0064E4 # Sunflower Plains 50 173 0x82 0xFFBFB755 0xFFAEA42A 0xFF00A0D4 # Desert Mountains 0 255 0x83 0xFF8AB689 0xFF6DA36B 0xFF0028F4 # Extreme Hills Mountains 203 239 0x84 0xFF445C34 0xFF32621D 0xFF3238AD # Flower Forest 76 112 0x9C 0xFF4B663A 0xFF485E30 0xFF2B39B2 # Birch Forest Hills Mountains 76 112 0x9D 0xFF2C431C 0xFF3D7723 0xFF0064E4 # Roofed Forest Mountains 76 112 0xA3 0xFF6F6A31 0xFF555014 0xFF0064E4 # Savanna Mountains 76 112 0xA4 0xFF6F6A31 0xFF555014 0xFF0064E4 # Savanna Plateau Mountains 76 112 0xA5 0xFF82B593 0xFF63A277 0xFF000EFB # Mesa Bryce 76 112 0xA6 0xFF82B593 0xFF63A277 0xFF000EFB # Mesa Plateau F Mountains 76 112 0xA7 0xFF82B593 0xFF63A277 0xFF000EFB # Mesa Plateau Mountains 76 112

I am not sure why they are reported as missing. I cannot detect a syntax error in the config file. I am assuming that somehow the config file stops being read at

0x27 0xFF82B593 0xFF63A277 0xFF000EFB # Mesa Plateau 76 112 since the next one is the 0x81 0xFF536B33 0xFF4F7020 0xFF0064E4 # Sunflower Plains 50 173

9B and others not in the sequence currently also appear in the list of missing biomes once I expand the map radius to be rendered. So somehow I feel confirmed that no biome codes beyond 0x27 are being read.

There is no error message however. I tried to set the biome codes to 0xFFFFFF81 instead of 0x81 but that caused an error. I wonder if the upper biomes are actually in a higher number than 0xFF and you need to change the size of the index_mask in line 36 of / src / togos / minecraft / maprend / BiomeMap.java

public static final int INDEX_MASK = 0xFF;

to

public static final int INDEX_MASK = 0xFFFFFFFF;

I am only guessing here however, I am not familiar with Java.

[TOGoS]

8-bit biome IDs were being treated as signed, so e.g. 129 was interpreted as 0xFFFFFF81. This is now fixed and there's a new JAR available (TMCMR-2013.12.17a.jar, at the usual location: http://www.nuke24.net/projects/TMCMR/).

[TOGoS]

Thanks for your patience and for helping to catch all these bugs, BTW.

[uncovery]

You are welcome. Thanks for making this mapper!