Closed LigH-de closed 7 years ago
I was not able to reproduce your averaging algorithm 100% exactly, but the remaining differences should be tiny. So, as good as it gets, I would suggest the following additions to block-colors.txt:
0x00CF:0x0 0x0901AB10 # Beetroot
0x00CF:0x1 0x0901AB10 # Beetroot
0x00CF:0x2 0x1701BB0F # Beetroot
0x00CF:0x3 0x1701BB0F # Beetroot
0x00CF:0x4 0x3600BE10 # Beetroot
0x00CF:0x5 0x3600BE10 # Beetroot
0x00CF:0x6 0x3600BE10 # Beetroot
0x00CF:0x7 0x65507135 # Beetroot
0x00D0 0xFF957C47 # Grass path
0x00D8 0xFFCDC9B1 # Bone block
Stage 0..6 of beetroot are identical to potatoes, only stage 7 is different (beige/purple).
Furthermore, you may like to fix "Unkonwn Sapling ID" to "Unknown Sapling ID".
Also enhanceable: Several sub-types of blocks. (§ Color values for subtypes 0x1..0x6 are probably not exact!)
0x0001 0xFF7D7D7D # Stone
0x0001:0x1 0xFF997162 # Granite
0x0001:0x2 0xFF9F7262 # Smooth Granite
0x0001:0x3 0xFFB3B3B6 # Diorite
0x0001:0x4 0xFFB7B7B9 # Smooth Diorite
0x0001:0x5 0xFF828383 # Andesite
0x0001:0x6 0xFF858586 # Smooth Andesite
Regarding saplings: Since MC v1.7 there are biome related types – just planted (0x0..0x5) or growing (0x8..0xD). Earlier there were less types and more growth steps.
0x0006:0x0 0x6B476625 # Oak Sapling
0x0006:0x1 0x53333A21 # Spruce Sapling
0x0006:0x2 0x6B769654 # Birch Sapling
0x0006:0x3 0x55305612 # Jungle Sapling
0x0006:0x4 0x55768E1D # Acacia Sapling
0x0006:0x5 0x55105210 # Dark Oak Sapling
0x0006:0x8 0x6B476625 # Growing Oak Sapling
0x0006:0x9 0x53333A21 # Growing Spruce Sapling
0x0006:0xA 0x6B769654 # Growing Birch Sapling
0x0006:0xB 0x55305612 # Growing Jungle Sapling
0x0006:0xC 0x55768E1D # Growing Acacia Sapling
0x0006:0xD 0x55105210 # Growing Dark Oak Sapling
Giant mushrooms have porous stems (§):
0x0063 0xFF8D6A53 # Huge Brown Mushroom
0x0063:0xA 0xFFCAAB78 # Huge Mushroom Stem
0x0064 0xFFB62524 # Huge Red Mushroom
0x0064:0xA 0xFFCAAB78 # Huge Mushroom Stem
And if you want to display the head (pillow) of the bed differently (§):
0x001A:0x0 0xFF8E1616 # Bed S foot
0x001A:0x1 0xFF8E1616 # Bed W foot
0x001A:0x2 0xFF8E1616 # Bed N foot
0x001A:0x3 0xFF8E1616 # Bed E foot
0x001A:0x8 0xFFAF7474 # Bed S head
0x001A:0x9 0xFFAF7474 # Bed W head
0x001A:0xA 0xFFAF7474 # Bed N head
0x001A:0xB 0xFFAF7474 # Bed E head
You can submit a pull request for the block-colors.txt with those in there or even fork the repository and add your own file. If you change the file you can embed it without compiling the jar by using the commandline switch -color-map $mapper_folder/block-colors.txt
Yes, I already use this file via CLI option (with some additional tweaks possibly not desired here).
I was unsure whether I should offer my results as a whole replacement because I know that my values are not exact, and the original author will probably have a tool to calculate the "MIP 0" alpha-weighted average pixel value of block images. But I guess the absolute difference may be at most 2 for each RGBA component.
I would just submit the changes. It's much easier to implement a pull request first and change the details later
I am not yet used to this workflow ... if I understood well, I would edit block-data/block-colors.txt and then create a new pull request according to the sample to compare "yesterday" with "now" (master@{1day}...master
)?
Just click on the link that you pasted and then on the pen in the top right corner, save it and the create pull request.
TOGoS appears to be quite busy, still... as he already stated to never use it anymore, it seems to be more or less abandoned now.
You might be right. You can always fork it and compile yourself
That would assume that I am a Java developer... but I am just a Java user, mainly. I don't see myself maintaining such a project.
Request got pulled - hoping for a new build after all recent patched got processed.
In MC 1.10+, some new block types are not yet mapped. Some were reported in the debug output:
There are certainly more... I don't know how you calculate the average block color, so I can't provide results of the same algorithm.