search

TOMP-WG / TOMP-API

Transport Operator to Mobility-as-a-Service Provider-API development for Mobility as a Service
Apache License 2.0
96 stars 41 forks source link

[FEATURE REQUEST] Flatten asset(type) structure #513

Open edwinvandenbelt opened 1 year ago

edwinvandenbelt commented 1 year ago

Is your feature request related to a problem? Please describe.

The asset and asset type both have the 'assetProperties' object in one of their properties. It creates an additional layer, where it actually are direct properties of the asset/assetType itself. The structure should be flattened.

Urgency

Minor (this feature is nice to have, no rush to implement this), because it reduces the amount of code

Additional context

when programming, the construct of 'assetProperties' is referred often. Code becomes more clear when it is removed

Describe the solution you'd like

Restructure asset and assetType with the 'allOf' keyword

Describe alternatives you've considered

Keep it the way it is. Disadvantage: see 'urgency'

eborremans commented 9 months ago

Before taking further action we should await the outcome of the TOMP Impact analysis decisions

edwinvandenbelt commented 7 months ago

https://github.com/TOMP-WG/TOMP-API/blob/transmodel-v1/TOMP-API.yaml Flattened: