search

TOMToolkit / make-tom

GNU General Public License v3.0
0 stars 0 forks source link

make_tom should not default to a python version not supported by TOM Toolkit. #5

Open jchate6 opened 6 months ago

jchate6 commented 6 months ago

Currently this defaults to the most recent python version (python 3.12) which is unsupported by TomToolkit

jchate6 commented 6 months ago

when asked the question about what python to use, I get the following: 

Checking for your installed Python...
Found Python 3.12.2 at /usr/bin/python
Do you want to use the Python 3.12.2 at /usr/bin/python? 
Type 'yes' or the pathname of an alternative python executable: (yes/</path/to/python>)? [yes]

It would be nice if I could request a different python VERSION rather than a different python PATH.

phycodurus commented 6 months ago

make-tom.sh is using the shell command command to get information on the installed version of Python. It's not defaulting to any specific version.

If the script asked for a Python VERSION rather than a PATH, it would have to assume the burden of finding the executable of the that Python, and I'd rather the user (who has the knowledge) assume that burden.

jchate6 commented 6 months ago

My issue is the default behavior that the script has when the local version of python is not compatible with TOM Toolkit. Instead of just installing from command -v python we could install from command -v python3.10 or some other compatible python version if the default was unsupported by tom_base.

Basically we could try python versions until we find a compatible one. If they don't have one in their path, the install would fail anyway.