djangorestframework>=3.15 is now required

[griffin-h]

953 uses the rest_framework.DefaultRouter.is_already_registered method, which was only introduced in djangorestframework v3.15. If the code is run with djangorestframework v3.14, the following error results:

Exception in thread django-main-thread:
Traceback (most recent call last):
  File "/Users/griffin/anaconda3/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/Users/griffin/anaconda3/lib/python3.10/threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/utils/autoreload.py", line 64, in wrapper
    fn(*args, **kwargs)
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/core/management/commands/runserver.py", line 133, in inner_run
    self.check(display_num_errors=True)
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/core/management/base.py", line 485, in check
    all_issues = checks.run_checks(
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/core/checks/registry.py", line 88, in run_checks
    new_errors = check(app_configs=app_configs, databases=databases)
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/core/checks/urls.py", line 14, in check_url_config
    return check_resolver(resolver)
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/core/checks/urls.py", line 24, in check_resolver
    return check_method()
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/urls/resolvers.py", line 494, in check
    for pattern in self.url_patterns:
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/utils/functional.py", line 57, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/urls/resolvers.py", line 715, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/utils/functional.py", line 57, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/urls/resolvers.py", line 708, in urlconf_module
    return import_module(self.urlconf_name)
  File "/Users/griffin/anaconda3/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/griffin/PycharmProjects/saguaro-tom/saguaro_tom/urls.py", line 22, in <module>
    path('', include('tom_common.urls')),
  File "/Users/griffin/PycharmProjects/saguaro-tom/venv/lib/python3.10/site-packages/django/urls/conf.py", line 38, in include
    urlconf_module = import_module(urlconf_module)
  File "/Users/griffin/anaconda3/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/griffin/tom_base/tom_common/urls.py", line 34, in <module>
    router.register(r'groups', GroupViewSet, 'groups')
  File "/Users/griffin/tom_base/tom_common/api_router.py", line 18, in register
    if self.shared_router.is_already_registered(basename):
AttributeError: 'DefaultRouter' object has no attribute 'is_already_registered'

[jchate6]

@griffin-h do you foresee a problem with updating our minimum requirements accordingly, or do you anticipate a more backwards compatible solution will be necessary?

[griffin-h]

I think updating the dependency will be fine, as long as it doesn't conflict with any other dependencies (which I didn't check).