User approval fails because 'A user with that username already exists'

[crpellegrino]

I'm testing user registration and approval within the "Approval Registration" workflow and ran into the following issue. I registered for an account with a dummy user. To approve the account, I logged in as my normal user, went to the User List page, and clicked "Approve" next to the dummy user under "Pending Users." Clicking "Approve" on this next page gives the error A user with that username already exists underneath the username form input field. My guess is that the form first tries to validate by checking if the username is unique here, and obviously the username is already taken by the user that's pending approval.

As a side note, I think it would be helpful to have a new templatetag for "approved users" or "existing users" as the current templatetag doesn't filter non-active users. On the User List page this makes pending users appear twice, which is a bit confusing.

[jchate6]

@crpellegrino I cannot reproduce your issue. Is the branch with this integrated into Snex2 on github?

Also, I feel like unapproved users simply shouldn't be listed as active users yet. Would this solve your side note?

[crpellegrino]

Here's a link to my branch with these changes and a screenshot of the problem, for reference.

https://github.com/crpellegrino/snex2/tree/feature/userregistration