search

TOPLLab / WARDuino

📟 A dynamic WebAssembly VM for embedded systems
https://topllab.github.io/WARDuino/
Mozilla Public License 2.0
80 stars 7 forks source link

Fix/pause #147

Closed tolauwae closed 1 year ago

tolauwae commented 1 year ago
carllocos commented 1 year ago

The code seems fine.

Can your tests verify that this source code change has no effect on the reception of Wasm state via interruptRecvState? That used to cause a race condition which was also the reason why I added the mutex some time ago (commit 376467a0bb2c808b9f8486ac5ae7518bb751fcfb)

tolauwae commented 1 year ago

The code seems fine.

Can your tests verify that this source code change has no effect on the reception of Wasm state via interruptRecvState? That used to cause a race condition which was also the reason why I added the mutex some time ago (commit 376467a)

Good to know I was wondering why that lock was there.

But EDWARD debugging stilled worked fine. And the mutex lock is not remove by the changes. In fact the ARDuino compile guard is removed so the race condition should not take place even if the probe is on a different platform.

https://github.com/TOPLLab/WARDuino/pull/147/files#diff-44824169c7a7daf4e59253fdeb16fef7614557350eed9f63080fc99baeca9637R118-R119