TOSIT-IO / tdp-collection

Ansible collection to deploy the components of TDP
Apache License 2.0
21 stars 19 forks source link

fix(ranger): add whitespace in order to fix templating #855

Closed PACordonnier closed 1 month ago

PACordonnier commented 2 months ago

Which issue(s) this PR fixes

Missing whitespace in install.properties.j2 create issue when ranger templates its site.

Heres an example of what the property is templated to in ranger-admin-site.xml by ranger's setup.sh

        <property>
                <name>ranger.spnego.kerberos.keytab</name>
                <value>/etc/security/keytabs/spnego.service.keytabtoken_valid=30</value>
        </property>

You can see that this small unfortunate mistake has been introduced by #844 here https://github.com/TOSIT-IO/tdp-collection/pull/844/files#diff-5d5bf852121faeb978b8b79af8454dea1115d35aae78b1803acd53e1608a44d9

Agreements

rpignolet commented 2 months ago

Maybe resolve with #852

rpignolet commented 2 months ago

852 is merged. Still relevant ?

PACordonnier commented 1 month ago

Fixed by #852