feat: diplays the repo if GitError

TOSIT-IO / tdp-lib

Python library to configure, manage and deploy TDP

Apache License 2.0

4 stars 8 forks source link

feat: diplays the repo if GitError #621

Open SteBaum opened 2 months ago

SteBaum commented 2 months ago

Which issue(s) this PR fixes

Fixes None

Additional comments

If an error occurs with the is_clean function of the GitRepository class, the concerned repository is printed in the trace.

Agreements

[x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

SteBaum commented 1 month ago

Yes sorry I should have copied the error I had. I had this error when I was executing TDP-lib in a container with a different user as on my host where tdp_vars were located and attached to the container through a volume. It could not access any git repository in this case. it had nothing to do with the code in tdp-lib and all git repositories were affected but in the case that only one would be affected we would not know which one it is, so this error message tells us precisely which one is concerned.

PaulFarault commented 1 month ago

Then I'm not sure that this PR is that useful. We never encountered this type of error and even if it occurs, your PR it only covering the is_clean method.

Furthermore, we already know to which repository the error comes from as the method is part of the Repository class.