TOSIT-IO / tdp-lib

Python library to configure, manage and deploy TDP
Apache License 2.0
4 stars 8 forks source link

Remove noop playbook check #629

Open PaulFarault opened 1 month ago

PaulFarault commented 1 month ago

Which issue(s) this PR fixes

Fixes None

Additional comments

This check become useless. We are currently creating the list of operations from the dag and eventually assign them a playbook if define. Dag operations with no associated playbook are then treated as "noop". Hence, we are not using the noop property anymore.

Furthermore, this check doesn't cover the case where a noop is defined in collection1 and then is completed with a playbook defined in collection2.

I suggest to also remove entirely the noop property from the dag files (in the collections) are it is not used anymore.

Agreements