search

TOSIT-IO / tdp-server

REST API for tdp-lib orchestration
2 stars 2 forks source link

GET /api/v1/deploy/failed/ endpoint #108

Open PaulFarault opened 1 year ago

PaulFarault commented 1 year ago

It would be nice to have an endpoint for retrieving failed deployments. It could be used along with the resume deploy endpoint.

Do you think that's a good idea or is it the client job to filter failed deployment from the whole list?

gboutry commented 1 year ago

It could be a good idea to be able to filter /api/v1/deploy by status like: /api/v1/deploy?status=failed or /api/v1/deploy?status=pending

gboutry commented 1 year ago

IMO, it's not a good idea to collect a list of failed deployment on the client side to generate a list of resumeable deployments.

gboutry commented 1 year ago

What are you trying to do ?

PaulFarault commented 1 year ago

That:

Collect a list of failed deployment on the client side to generate a list of resumeable deployments.

My initial use case is linked to https://github.com/TOSIT-IO/tdp-ui/issues/124 . I was wondering if I needed to add a "Resume" option with a list of all failed deployments to resume. It seems not.

However, this issue can be still relevant if we want to implement filtering options on the log pages (by date, status etc.).