Closed sergkudinov closed 1 year ago
@rpignolet @PaulFarault
If the file openapi-generator-cli.jar
is already present, the generate.sh
script output this:
Downloading https://repo1.maven.org/maven2/org/openapitools/openapi-generator-cli/6.2.0/openapi-generator-cli-6.2.0.jar
File ‘openapi-generator-cli.jar’ already there; not retrieving.
schemas/tdp-server_0.1.0_openapi.json: OK
No schema change. Skipping client generation...
If you want to force client generation, set the variable 'FORCE_OPENAPI_GEN=TRUE'
I think it already works, if the file is present the script will not download it no ?
Indeed, no need for --skip-download
, but anyway it needs refactoring.
So, I suggest:
OPENAPI_JAR_URL
with the default https://repo1.maven.org/maven2/org/openapitools/openapi-generator-cli/6.2.0/openapi-generator-cli-6.2.0.jar
.
In air-gapped environment, we manage the
openapi-generator-cli-6.2.0.jar
file differently. So there is no need forwget
to download it.My suggestion is to add
--skip-download
option togenerate.sh
script and anif
construction. I would also refactorFORCE_OPENAPI_GEN
into cli command option-f
/--force
to make it look more fancy (similar tosetup.sh
)